Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud/aws: add a third secure instance fallback across AZs #4401

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

croissanne
Copy link
Member

In case the on demand option failed as well, retry one more time across availability zones. This significantly increases the pool of available instances, but increases network related costs, as transferring data between AZs is not free.

In case the on demand option failed as well, retry one more time across
availability zones. This significantly increases the pool of available
instances, but increases network related costs, as transferring data
between AZs is not free.
Copy link
Contributor

@schuellerf schuellerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, seems to do what it should do.
Does it make sense to introduce prometheus metrics/counter for those cases to have better overview/statistics? (probably a separate implementation/PR)

@croissanne
Copy link
Member Author

lgtm, seems to do what it should do. Does it make sense to introduce prometheus metrics/counter for those cases to have better overview/statistics? (probably a separate implementation/PR)

The problem is that this runs on the worker, so there's no way to get the data into prometheus unless we want to somehow forward that to composer.

@croissanne croissanne merged commit 905df41 into osbuild:main Oct 7, 2024
48 of 50 checks passed
@croissanne croissanne deleted the fallback-across-azs-si branch October 7, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants